Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drivers #14

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Drivers #14

merged 10 commits into from
Sep 11, 2024

Conversation

benmerckx
Copy link
Owner

@benmerckx benmerckx commented Sep 10, 2024 •
edited
Loading

Restructure drivers so we can import them as such:

import Database from 'better-sqlite3'
import {'better-sqlite3' as connect} from 'rado/driver'

const db = connect(new Database())

Instead of:

import Database from 'better-sqlite3'
import {connect} from 'rado/driver/better-sqlite3'

const db = connect(new Database())

This helps with publishing deno drivers to jsr where we can't use @ in export names. Drivers are extremely minimal in code and do not import anything so this won't have the usual barrel file problems. I'll keep the imports around as well.

@benmerckx benmerckx merged commit 8e307fe into main Sep 11, 2024
3 checks passed
@benmerckx benmerckx deleted the drivers branch September 11, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benmerckx